|
From: | percival . music . ca |
Subject: | Re: remove bar-size and replace its usage by bar-extent (issue4025044) |
Date: | Sun, 23 Jan 2011 15:00:28 +0000 |
Passes regtests, but a few minor nitpicks. http://codereview.appspot.com/4025044/diff/10001/input/regression/bar-extent.ly File input/regression/bar-extent.ly (right): http://codereview.appspot.com/4025044/diff/10001/input/regression/bar-extent.ly#newcode1 input/regression/bar-extent.ly:1: \version "2.12.3" I think this should be 2.13.47 ? http://codereview.appspot.com/4025044/diff/10001/input/regression/bar-extent.ly#newcode2 input/regression/bar-extent.ly:2: Sorry for missing this earlier: we need a \header { \texidoc=""}} thing. Take a look at any of the other regtests. :) http://codereview.appspot.com/4025044/diff/10001/input/regression/drums.ly File input/regression/drums.ly (right): http://codereview.appspot.com/4025044/diff/10001/input/regression/drums.ly#newcode10 input/regression/drums.ly:10: \version "2.13.46" 2.13.47 http://codereview.appspot.com/4025044/diff/10001/input/regression/grid-lines.ly File input/regression/grid-lines.ly (right): http://codereview.appspot.com/4025044/diff/10001/input/regression/grid-lines.ly#newcode8 input/regression/grid-lines.ly:8: \version "2.13.46" 2.13.47 http://codereview.appspot.com/4025044/diff/10001/input/regression/lyrics-bar.ly File input/regression/lyrics-bar.ly (right): http://codereview.appspot.com/4025044/diff/10001/input/regression/lyrics-bar.ly#newcode1 input/regression/lyrics-bar.ly:1: \version "2.13.46" 2.13.47 http://codereview.appspot.com/4025044/diff/10001/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/4025044/diff/10001/ly/engraver-init.ly#newcode19 ly/engraver-init.ly:19: \version "2.13.46" 2.13.47 http://codereview.appspot.com/4025044/
[Prev in Thread] | Current Thread | [Next in Thread] |