[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: remove bar-size and replace its usage by bar-extent (issue4025044)
From: |
n . puttock |
Subject: |
Re: remove bar-size and replace its usage by bar-extent (issue4025044) |
Date: |
Thu, 27 Jan 2011 23:46:31 +0000 |
Hi Pál,
LGTM apart from the change in behaviour for dashed barlines: they're
overshooting the outer lines. I couldn't see this from the regtest
comparison for bar-line-dashed.ly, but it's clearly visible on paper.
Cheers,
Neil
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc
File lily/bar-line.cc (left):
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc#oldcode135
lily/bar-line.cc:135: {
remove { }
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc#oldcode140
lily/bar-line.cc:140: {
remove { }
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc
File lily/bar-line.cc (right):
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc#newcode37
lily/bar-line.cc:37: {
remove { }
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc#newcode72
lily/bar-line.cc:72: if (ex.length() > 0)
length ()
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc#newcode113
lily/bar-line.cc:113: Real const h = extent.length();
length ()
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc#newcode325
lily/bar-line.cc:325: Real const h = extent.length();
length ()
http://codereview.appspot.com/4025044/diff/20001/lily/span-bar.cc
File lily/span-bar.cc (right):
http://codereview.appspot.com/4025044/diff/20001/lily/span-bar.cc#newcode80
lily/span-bar.cc:80: {
remove { }
http://codereview.appspot.com/4025044/
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), percival . music . ca, 2011/01/21
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), benko . pal, 2011/01/21
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), percival . music . ca, 2011/01/23
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), benko . pal, 2011/01/23
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), percival . music . ca, 2011/01/23
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), Carl . D . Sorensen, 2011/01/23
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), pkx166h, 2011/01/26
- Re: remove bar-size and replace its usage by bar-extent (issue4025044),
n . puttock <=
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), benko . pal, 2011/01/28
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), hanwenn, 2011/01/31