[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Add dots to tocItemMarkup (issue4182056)
From: |
Carl . D . Sorensen |
Subject: |
Add dots to tocItemMarkup (issue4182056) |
Date: |
Wed, 16 Feb 2011 13:23:00 +0000 |
Looks very good.
Just a couple more comments.
Thanks,
Carl
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode994
scm/define-markup-commands.scm:994: (define (nest-patterns pattern
pattern-width distance count patterns)
It might be even better if this were defined as a markup command, for
example pattern-markup. Then anybody else (like me) could use it for
making a repeating pattern of markups (like a LyricExtender for shape
notes).
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode1032
scm/define-markup-commands.scm:1032: (x-offset (+ (* (- (- middle-width
(* patterns-number period)) pattern-width) (/ (1+ dir) 2)) (abs (car
pattern-x-extent)))))
Wrap to proper formatting at about 80 characters.
http://codereview.appspot.com/4182056/
- Add dots to tocItemMarkup (issue4182056),
Carl . D . Sorensen <=
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), Carl . D . Sorensen, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), Carl . D . Sorensen, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/18
- Re: Add dots to tocItemMarkup (issue4182056), percival . music . ca, 2011/02/22
- Re: Add dots to tocItemMarkup (issue4182056), n . puttock, 2011/02/23
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/23
- Re: Add dots to tocItemMarkup (issue4182056), percival . music . ca, 2011/02/24