Re: Wrong loop boundaries when iterating over markup list (issue4236047)

[pnorcks]

Hi Boris,

Just a code nitpick (in two places).

Please remember to Cc: lilypond-devel for Rietveld patches so that we
know code review is taking place.

Thanks,
Patrick


http://codereview.appspot.com/4236047/diff/1/lily/paper-book.cc
File lily/paper-book.cc (right):

http://codereview.appspot.com/4236047/diff/1/lily/paper-book.cc#newcode540
lily/paper-book.cc:540: (list == texts) &&
(scm_is_pair(scm_cdr(list)))); // I am first && there is more stuff
There should be spaces before all open parens:

  (scm_is_pair (scm_cdr (list)))

http://codereview.appspot.com/4236047/diff/1/lily/paper-book.cc#newcode542
lily/paper-book.cc:542: (!scm_is_pair(scm_cdr(list))) && (list !=
texts)); // I am last && not first
My previous comment applies here, too.

http://codereview.appspot.com/4236047/