Re: Adds beam collision avoidance to auto beaming (issue4290069)

[hanwenn]

http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc
File lily/beam-collision-engraver.cc (right):

http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55
lily/beam-collision-engraver.cc:55: if (covered_grobs_.size ())
to drop 1 indent level, do

 if (covered.empty())
   return;

http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode81
lily/beam-collision-engraver.cc:81: start = 0;
what graham said.

Maybe you can add a comment about how you're going about it?

In particular, the logic around start looks odd.

i'd write something like this:

for (i over beams) {
  while (covered[start].rank[left] < beam[i].right)
    start++

  for (j = start; covered[j] < beam.right; j++) {
    ..maybe add covered[j] to beam[i]..
  }
}

http://codereview.appspot.com/4290069/