Re: Adds beam collision avoidance to auto beaming (issue4290069)

[mtsolo]

New patch set uploaded.


http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc
File lily/beam-collision-engraver.cc (right):

http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode50
lily/beam-collision-engraver.cc:50: sort (covered_grobs_.begin (),
covered_grobs_.end (), Grob::less);
On 2011/03/28 20:50:09, Neil Puttock wrote:
> vector_sort (covered_grobs_, Grob::less);

Done.

http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode51
lily/beam-collision-engraver.cc:51: sort (beams_.begin (), beams_.end
(), Grob::less);
On 2011/03/28 20:50:09, Neil Puttock wrote:
> vector_sort (beams_, Grob::less);

Done.

http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode54
lily/beam-collision-engraver.cc:54: if (!covered_grobs_.size ())
On 2011/03/28 20:50:09, Neil Puttock wrote:
> You probably want this at the top.

Done.

http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode59
lily/beam-collision-engraver.cc:59: // Start conisdering grobs at the
first grob whose end falls at or after the beams beginning.
On 2011/03/28 20:50:09, Neil Puttock wrote:
> considering

> beam's

Done.

http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode66
lily/beam-collision-engraver.cc:66: Only consider grobs whose end falls
at or after the beams beginning.
On 2011/03/28 20:50:09, Neil Puttock wrote:
> beam's

Done.

http://codereview.appspot.com/4290069/