[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allows glissandi between chords (issue4442082)
From: |
address@hidden |
Subject: |
Re: Allows glissandi between chords (issue4442082) |
Date: |
Thu, 28 Apr 2011 10:04:38 -0400 |
On Apr 28, 2011, at 9:47 AM, address@hidden wrote:
>
> http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly
> File input/regression/glissando-chord.ly (right):
>
> http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly#newcode4
> input/regression/glissando-chord.ly:4: texidoc = "LilyPond typesets
> glissandi between chords."
> This should be two separate tests: one for the basic functionality and
> another testing 'glissando-index.
>
> http://codereview.appspot.com/4442082/diff/3001/lily/glissando-engraver.cc
> File lily/glissando-engraver.cc (right):
>
> http://codereview.appspot.com/4442082/diff/3001/lily/glissando-engraver.cc#newcode51
> lily/glissando-engraver.cc:51: SCM map;
> Unless you need to preserve the value of glissandoMap between timesteps,
> this is redundant.
>
> http://codereview.appspot.com/4442082/diff/3001/lily/glissando-engraver.cc#newcode85
> lily/glissando-engraver.cc:85: map = get_property ("glissandoMap");
> SCM map = get_property ("glissandoMap");
>
> (see note above)
>
> http://codereview.appspot.com/4442082/
All fixed in 5eba06f78bb08b84415544ed9e3cf0171a830aa6.
Cheers,
MS
Re: Allows glissandi between chords (issue4442082), mtsolo, 2011/04/27
Re: Allows glissandi between chords (issue4442082), percival . music . ca, 2011/04/28
Re: Allows glissandi between chords (issue4442082), Carl Sorensen, 2011/04/28
Re: Allows glissandi between chords (issue4442082), n . puttock, 2011/04/28
- Re: Allows glissandi between chords (issue4442082),
address@hidden <=