Re: Another fix candidate for issue 1613. (issue4426072)

[address@hidden]

On May 1, 2011, at 5:24 AM, address@hidden wrote:

> 
> http://codereview.appspot.com/4426072/diff/4002/lily/beam.cc
> File lily/beam.cc (right):
> 
> http://codereview.appspot.com/4426072/diff/4002/lily/beam.cc#newcode1329
> lily/beam.cc:1329: while (dirty);
> this looks fishy; what guarantees that the loop will terminate?
> 
>  forbidden is
> 
>    [ (-inf, 2), (1, inf) ]
> 
> this will loop forever?
> 

I think that line 1320 prohibits that:

              if (!(forbidden_intervals[i][d] == d*infinity_f) && 
forbidden_intervals[i].contains (feasible_beam_placements[d]))

So long as the sign on the infinity is negative if DOWN and positive if UP 
(which I can't imagine it not being given the way the code above works), these 
should be screened out.

Cheers,
MS