[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Better approach to fixing the TabVoice glissando problem. (issue4438092)
From: |
mtsolo |
Subject: |
Better approach to fixing the TabVoice glissando problem. (issue4438092) |
Date: |
Tue, 03 May 2011 03:56:15 +0000 |
Reviewers: ,
Message:
A better approach to the TabVoice glissando problem, although I'm still
not quite sure why it works, but it seems to work!
Cheers,
MS
Description:
Better approach to fixing the TabVoice glissando problem.
Please review this at http://codereview.appspot.com/4438092/
Affected files:
M lily/tab-note-heads-engraver.cc
Index: lily/tab-note-heads-engraver.cc
diff --git a/lily/tab-note-heads-engraver.cc
b/lily/tab-note-heads-engraver.cc
index
958c85d3e7d5b55bdecd2c33d5a19c1483c40c23..adf1f8c14bdd0b528d3214ba0bae34691a1557df
100644
--- a/lily/tab-note-heads-engraver.cc
+++ b/lily/tab-note-heads-engraver.cc
@@ -112,7 +112,7 @@ Tab_note_heads_engraver::process_music ()
vsize index;
if (string_fret_finger != SCM_EOL)
- for (vsize i = 0; i < fret_count; i++)
+ for (vsize i = fret_count; i--;)
{
note_entry = scm_list_ref (string_fret_finger, scm_from_int (i));
string_number = scm_car (note_entry);
- Better approach to fixing the TabVoice glissando problem. (issue4438092),
mtsolo <=
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), n . puttock, 2011/05/03
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), address@hidden, 2011/05/03
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), Neil Puttock, 2011/05/03
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), address@hidden, 2011/05/03
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), address@hidden, 2011/05/03
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), Neil Puttock, 2011/05/04
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), address@hidden, 2011/05/06
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), Carl Sorensen, 2011/05/06
- Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), Carl Sorensen, 2011/05/07
Re: Better approach to fixing the TabVoice glissando problem. (issue4438092), n . puttock, 2011/05/03