[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: make doc

From: Graham Percival
Subject: Re: make doc
Date: Fri, 3 Jun 2011 11:43:09 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Thu, Jun 02, 2011 at 06:31:47PM +0100, Phil Holmes wrote:
> We need to edit lilypond-book.  The relevant line is:
> system_in_directory (' '.join ([cmd, ly.mkarg (name)]),
>                         lily_output_dir)


> The system command is found in
> system = subprocess_system
> if sys.platform == 'mingw32':
>    ## subprocess x-compile doesn't work.
>    system = ossystem_system

Hmm.  That might be an old check; I'd be surprised if current
versions of python have the same problem.  That said, GUB still
uses python 2.4 IIRC, and changing that would open up a much huger
can of worms.

That said, you'll need to modify ossystem_system in addition to
subprocess_system.  :(    oh wait, second thought: just do
subprocess_system, and we'll look at the other one later.

> def subprocess_system (cmd,
>                       ignore_error=False,
>                       progress_p=True,
>                       be_verbose=False,
>                       log_file=None):
> That's interesting - it already has a log_file parameter - which
> isn't used....


> If we change this to something like:
>    out = open('stdout.txt', 'w')
>    proc = subprocess.Popen (cmd,
>        shell=True,
>        universal_newlines=True,
>        stdout=out,
>        stderr=out)
>    out.close()

That looks quite reasonable, although I prefer your suggestion of
two files: a lily-1234-stdout.log and a lily-1234-sterr.log

Please upload a patch.  :)

- Graham

reply via email to

[Prev in Thread] Current Thread [Next in Thread]