[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bugfix for issue 1630 (issue4490045)
From: |
Janek Warchoł |
Subject: |
Re: Bugfix for issue 1630 (issue4490045) |
Date: |
Wed, 15 Jun 2011 00:19:01 +0200 |
2011/6/14 <address@hidden>
>
> http://codereview.appspot.com/4490045/diff/30001/lily/tie-engraver.cc#newcode157
> lily/tie-engraver.cc:157: maybe should check positions too.
> On 2011/06/14 21:36:59, Neil Puttock wrote:
>>
>> looks like tab -> space conversion going on here (and below);
>> please restore and only fix bad indents
>
> Neil, you are absolutely correct (as always).
>
> However, I have a proposal for Karen
it's Karin :)
> and Janek: you are probably quite
> confused (and maybe disheartened) by this indentation problem, because
> the current indentation policy used in lilypond is completely braindead
> and ridiculous for any editor other than GNU/emacs.
I'm disheartened by the idea of reverting tab->space conversion,
because CG 10.3.2 says "All indentation should be done with spaces".
> I have just postponed the "lessons from 2.14" GOP policy question for
> another week so that we can start dealing with "C++ indentation" on Wed
> 22 June. Unfortunately the discussion would not be over until 06 July,
> but that's the best I can do (unless I postpone the "mentors"
> discussion, but I think that one's even more pressing than indentation).
No, don't postpone mentors!
> If you want the patch pushed sooner, then unfortunately you need to use
> the exact (braindead) indentation we currently have for C++ code.
> Alternately, wait until we have a sensible policy
I think we are inconsistent: sometimes we stick to the rules very
strictly, and sometimes not at all.
Janek
- Re: Bugfix for issue 1630 (issue4490045), (continued)
- Re: Bugfix for issue 1630 (issue4490045), karin . hoethker, 2011/06/13
- Re: Bugfix for issue 1630 (issue4490045), percival . music . ca, 2011/06/13
- Re: Bugfix for issue 1630 (issue4490045), lemniskata . bernoullego, 2011/06/14
- Re: Bugfix for issue 1630 (issue4490045), percival . music . ca, 2011/06/14
- Re: Bugfix for issue 1630 (issue4490045), n . puttock, 2011/06/14
- Re: Bugfix for issue 1630 (issue4490045), n . puttock, 2011/06/14
- Re: Bugfix for issue 1630 (issue4490045), percival . music . ca, 2011/06/14
- Re: Bugfix for issue 1630 (issue4490045),
Janek Warchoł <=
- Re: Bugfix for issue 1630 (issue4490045), lemniskata . bernoullego, 2011/06/14
- Re: Bugfix for issue 1630 (issue4490045), percival . music . ca, 2011/06/14
- Re: Bugfix for issue 1630 (issue4490045), lemniskata . bernoullego, 2011/06/15
- Re: Bugfix for issue 1630 (issue4490045), percival . music . ca, 2011/06/15