[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Modifies Spanner::spanner_length to better handle line-spanners. (is
|
From: |
address@hidden |
|
Subject: |
Re: Modifies Spanner::spanner_length to better handle line-spanners. (issue4621044) |
|
Date: |
Thu, 16 Jun 2011 10:36:44 +0200 |
On Jun 15, 2011, at 10:39 PM, address@hidden wrote:
> LGTM.
>
>
> http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc
> File lily/spanner.cc (right):
>
> http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode243
> lily/spanner.cc:243:
> whitespace
>
> http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode249
> lily/spanner.cc:249: lr[d] = robust_scm2double (ly_assoc_get
> (ly_symbol2scm ("X"),
> indent:
>
> do
> lr[d] = robust_scm2double (ly_assoc_get (ly_symbol2scm ("X"),
>
> http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode252
> lily/spanner.cc:252:
> whitespace
>
> http://codereview.appspot.com/4621044/
Clean regtests, so changes made and pushed.
d02c9ba13cc3a7c96cc6374e232e94501a833ed1
Cheers,
MS