[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds glissando stems to Lilypond. (issue4661061)
From: |
n . puttock |
Subject: |
Re: Adds glissando stems to Lilypond. (issue4661061) |
Date: |
Thu, 30 Jun 2011 15:29:30 +0000 |
Hi Mike,
The interface is an improvement on the patch you originally posted, but
it still leaves a lot to be desired. :)
I don't like the way you flag the glissando stems; ideally they'd be a
separate grob which doesn't require noteheads and legers to be removed.
Cheers,
Neil
http://codereview.appspot.com/4661061/diff/13/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4661061/diff/13/lily/stem.cc#newcode532
lily/stem.cc:532: Grob *glissando_column = unsmob_grob (me->get_object
("glissando-column"));
glissando-column is unused
http://codereview.appspot.com/4661061/diff/13/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/4661061/diff/13/ly/music-functions-init.ly#newcode386
ly/music-functions-init.ly:386: 'ignore-in-relative #t
you don't need this, since there's already a callback for relative mode
which you can override:
'to-relative-callback (lambda (music pitch) pitch)
-> ignore these pitches in relative mode
http://codereview.appspot.com/4661061/
- Adds glissando stems to Lilypond. (issue4661061), mtsolo, 2011/06/30
- Re: Adds glissando stems to Lilypond. (issue4661061), pkx166h, 2011/06/30
- Re: Adds glissando stems to Lilypond. (issue4661061), mtsolo, 2011/06/30
- Re: Adds glissando stems to Lilypond. (issue4661061), hanwenn, 2011/06/30
- Re: Adds glissando stems to Lilypond. (issue4661061),
n . puttock <=
- Re: Adds glissando stems to Lilypond. (issue4661061), mtsolo, 2011/06/30
- Re: Adds glissando stems to Lilypond. (issue4661061), ColinPKCampbell, 2011/06/30