[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Implements multiple-line non-cross-staff glissandi (issue4527086)
From: |
hanwenn |
Subject: |
Re: Implements multiple-line non-cross-staff glissandi (issue4527086) |
Date: |
Fri, 01 Jul 2011 14:41:10 +0000 |
http://codereview.appspot.com/4527086/diff/31002/scm/output-lib.scm
File scm/output-lib.scm (right):
http://codereview.appspot.com/4527086/diff/31002/scm/output-lib.scm#newcode798
scm/output-lib.scm:798: (define-public (glissando::before-line-breaking
grob)
before/after-linebreaking methods should only be used for manipulating
pointers between objects.
this computation here can be done with properties. Can you adopt an
action to change this?
http://codereview.appspot.com/4527086/diff/31002/scm/output-lib.scm#newcode809
scm/output-lib.scm:809: (y (+ (interval-center (ly:grob-extent bound
common-y Y))
this may trigger vertical staff positioning (which can only done after
line breaks). before/after-linebreaking methods should only be used for
manipulating pointers
between objects, and everything else should use callbacks on properties.
Can you adopt an action item to change this?
http://codereview.appspot.com/4527086/