lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds a warning for non-list fingeringOrientations settings. (issue46


From: address@hidden
Subject: Re: Adds a warning for non-list fingeringOrientations settings. (issue4650070)
Date: Tue, 5 Jul 2011 09:26:58 +0200

On Jul 4, 2011, at 4:39 PM, Neil Puttock wrote:

> On 4 July 2011 15:31, Carl Sorensen <address@hidden> wrote:
>> Would a redundant check of settings from default context definitions be a
>> problem?  I can't imagine that such a check would take 1% of the processing
>> time.
> 
> I don't know, though I agree is unlikely to be a significant overhead.
> 
>> Plus, I don't think it's really a redundant check; I think it's a real
>> check.   Absent such a check, we're trusting on the *-init.ly files being
>> correct, which admits a potential programming error.
> 
> The *-init.ly files are covered by regression testing since
> -dcheck-internal-types triggers an assertion error for incorrect
> context property settings.
> 
> Cheers,
> Neil
> 

Just to get the ball rolling on this, were I to start on a patch that 
implements this sort of settings checking, where would be a good place to start?
I know where the context mods are set and where the properties are set, but I 
don't know how the layout block escapes this checking.

Cheers,
MS


reply via email to

[Prev in Thread] Current Thread [Next in Thread]