lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)


From: hanwenn
Subject: Re: Allows for rider grobs in outside-staff-priority. (issue4639075)
Date: Thu, 14 Jul 2011 13:51:14 +0000

much better.  I bet there will skeletons coming out the regtest closet
now, but let's hope that we can fix things up if necessary


http://codereview.appspot.com/4639075/diff/23001/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

http://codereview.appspot.com/4639075/diff/23001/lily/axis-group-interface.cc#newcode673
lily/axis-group-interface.cc:673: ? (scm_is_number (me->get_property
("outside-staff-priority"))
why the null check? - I'd move the null check to the caller.

http://codereview.appspot.com/4639075/diff/23001/lily/axis-group-interface.cc#newcode675
lily/axis-group-interface.cc:675: || has_outside_staff_parent
(me->get_parent (Y_AXIS)))
shouldnt this only trigger for Y axis?

http://codereview.appspot.com/4639075/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]