[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: git-cl is down
From: |
Graham Percival |
Subject: |
Re: git-cl is down |
Date: |
Sun, 17 Jul 2011 00:32:38 -0700 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sat, Jul 16, 2011 at 07:35:50PM -0600, Carl Sorensen wrote:
> Now Bertrand's repository doesn't have one commit on this branch, he has
> three or four commits on his branch. And the first two or three are not
> right -- they haven't passed code review.
oh, I see. I personally always just modify the original commit --
in lily-git.tcl, it's option 2b instead of 2a. So I don't think
in terms of multiple commits for each rietveld issue.
> Since we're only ready for committing after getting approval, we need to
> combine into a single commit after approval. Either you can do it (creating
> your own metadata, as you said) or he can do it (using git rebase -i). But
> somebody needs to make the change to the commits in order get them ready for
> pushing.
If one keeps separate commits like this, then yes, somebody needs
to manually make those changes. I now understand why you were
foucsing on the "multiple commits" aspect of this problem.
Cheers,
- Graham
- Re: git-cl is down, (continued)
- Re: git-cl is down, Graham Percival, 2011/07/16
- Re: git-cl is down, Reinhold Kainhofer, 2011/07/16
- Re: git-cl is down, Bertrand Bordage, 2011/07/16
- Re: git-cl is down, Carl Sorensen, 2011/07/16
- Re: git-cl is down, Graham Percival, 2011/07/16
- Re: git-cl is down, Carl Sorensen, 2011/07/16
- Re: git-cl is down, Graham Percival, 2011/07/16
- Re: git-cl is down, Reinhold Kainhofer, 2011/07/16
- Re: git-cl is down, Carl Sorensen, 2011/07/16
- Re: git-cl is down,
Graham Percival <=
- Re: git-cl is down, Jan Warchoł, 2011/07/17
- Re: git-cl is down, Bertrand Bordage, 2011/07/22
- Re: git-cl is down, Graham Percival, 2011/07/23
Re: git-cl is down, Bertrand Bordage, 2011/07/16
Re: git-cl is down, Jan Warchoł, 2011/07/16