[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Checks for grobs with circular parentage in the regtests. (issue4747
From: |
Han-Wen Nienhuys |
Subject: |
Re: Checks for grobs with circular parentage in the regtests. (issue4747045) |
Date: |
Sun, 17 Jul 2011 21:50:15 -0300 |
On Sat, Jul 16, 2011 at 12:31 PM, address@hidden
<address@hidden> wrote:
>
> I'm gonna pull this patch out of consideration - both you and Neil are right
> about checking parents on an axis-by-axis basis. My desire to do this comes
> from an incomplete understanding of what "parent" means in LilyPond speak. I
> now understand that grob A can be grob B's X parent while grob B is grob A's
> Y parent. In this case, the approach in my tuplet patch holds because I only
> check along the Y_AXIS (as Carl suggested), which eliminates the recursive
> problem.
Also, code that actually creates loops would never finish compiling. We do
obj->relative_coordinate(system, axis)
in some place, and if there were a loop, this would never exit.
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen