lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix issues 1259 and 1433 (\breakDynamicSpan and a spanner's style=#


From: n . puttock
Subject: Re: Fix issues 1259 and 1433 (\breakDynamicSpan and a spanner's style=#'none over a line break) (issue4630070)
Date: Thu, 21 Jul 2011 18:48:50 +0000


http://codereview.appspot.com/4630070/diff/17001/input/regression/dynamics-alignment-breaker-linebreak.ly
File input/regression/dynamics-alignment-breaker-linebreak.ly (right):

http://codereview.appspot.com/4630070/diff/17001/input/regression/dynamics-alignment-breaker-linebreak.ly#newcode5
input/regression/dynamics-alignment-breaker-linebreak.ly:5: dynamic
spanner is across a line break.
crosses a line break

http://codereview.appspot.com/4630070/diff/17001/input/regression/dynamics-alignment-breaker-linebreak.ly#newcode9
input/regression/dynamics-alignment-breaker-linebreak.ly:9: % Both lines
should give the same output, although the \breakDynamicSpan
should go in texidoc

Edit: actually, I'm a bit confused since there are three lines and
they're all different

http://codereview.appspot.com/4630070/diff/17001/lily/dynamic-align-engraver.cc
File lily/dynamic-align-engraver.cc (right):

http://codereview.appspot.com/4630070/diff/17001/lily/dynamic-align-engraver.cc#newcode49
lily/dynamic-align-engraver.cc:49: Spanner *ended_line_; // Spanner was
manually broken, create a new one, but store the old so we can properly
finish it.
comment is a bit long

http://codereview.appspot.com/4630070/diff/17001/lily/dynamic-align-engraver.cc#newcode93
lily/dynamic-align-engraver.cc:93: programming_error ("Already have a
force-ended DynamicLineSpanner.");
"already have a force-ended DynamicLineSpanner"

http://codereview.appspot.com/4630070/diff/17001/lily/dynamic-align-engraver.cc#newcode134
lily/dynamic-align-engraver.cc:134: // TODO: Compare the direction of
the existing spanner with
remove

(issue #1111)

http://codereview.appspot.com/4630070/diff/17001/lily/dynamic-align-engraver.cc#newcode189
lily/dynamic-align-engraver.cc:189: bool end = line_ && (running_.empty
());
&& running_.empty ();

http://codereview.appspot.com/4630070/diff/17001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4630070/diff/17001/scm/define-grob-properties.scm#newcode780
scm/define-grob-properties.scm:780: (spanner-broken ,boolean? "Indicates
whether dynamics spanner
internal?

I'd remove any reference to dynamics here, since this is generic enough
to be useful elsewhere (e.g. pedals)

http://codereview.appspot.com/4630070/diff/17001/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4630070/diff/17001/scm/define-grobs.scm#newcode812
scm/define-grobs.scm:812: (spanner-broken . #f)
remove

http://codereview.appspot.com/4630070/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]