[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: review process not working

From: Jan Nieuwenhuizen
Subject: Re: review process not working
Date: Tue, 26 Jul 2011 11:22:50 +0200
User-agent: Gnus/5.110016 (No Gnus v0.16) Emacs/23.3 (cygwin)

David Kastrup writes:

> The overall code makes obvious that this has been created by a
> comparative novice to the programming languages and data structures of
> Lilypond.  He has been doing his best.

Good catch.  The patch also

@@ -208,63 +221,46 @@ Multi_measure_rest::church_rest (Grob *me, Font_metric 
*musfont, int measures,
   SCM mols = SCM_EOL;
-  /* See Wanske pp. 125  */
   int l = measures;
   int count = 0;

removes a reference to literature, which is very bad.  Although I agree
that the comment could elaborate a bit on what Wanske says on page 125,
I don't think we want this kind of references removed.

I think this patch should be reverted, moved to Rietveld, and worked on.


Jan Nieuwenhuizen <address@hidden> | GNU LilyPond
Freelance IT | AvatarĀ®

reply via email to

[Prev in Thread] Current Thread [Next in Thread]