lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Anything speaking against this simplification?


From: Carl Sorensen
Subject: Re: Anything speaking against this simplification?
Date: Sat, 30 Jul 2011 14:28:21 -0600

On 7/30/11 2:19 PM, "David Kastrup" <address@hidden> wrote:

> 
> 
> Hi,
> 
> music_list in parser.yy temporarily maintains an awkward
> half-self-referential data structure in order to have "fast append".  It
> makes more sense in my opinion to use prepend and reverse afterwards.
> "Fast append" in theory may show minimally better cache coherency at the
> cost of uglier code and uglier data structures.  So I'd just like to do
> the following (no full regtest yet).
> 
> Comments?
> 

It seems to me that this change may lead to larger guile memory usage, as
well.

I am generally in favor of making the code more clean and the data
structures simpler, so I like your changes in theory.

However, I think that where we have claims that something is done for speed,
we need to have a comparison that shows how speed is affected when it's
changed, before we can accept the change.

So in principle I'm in favor, but I'd like to see the affect on speed and
memory usage, both with the regtests and with a large score.

Thanks,

Carl




reply via email to

[Prev in Thread] Current Thread [Next in Thread]