|
From: | bordage . bertrand |
Subject: | Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068) |
Date: | Sun, 31 Jul 2011 15:35:46 +0000 |
Hi Pál (besides, are you Pál Benkő the chess master?) Thanks for this nice review.
1. about the very existence of usable-duration-logs - ok, it's generic, but who uses this genericity? is it not always (0 -1 -2 -3)? is it not always a range with lower end -3? is it not always a range?
It can be something else. Some recent editors are also using half and quarter rests. One may also want to only have whole rests, so I guess we don't have to hard-code -3. I don't honestly know if this has to be range or if bounds would be enough. I solved the issue I mentioned in the last comment, so that church rests only pick duration logs from usable-duration-logs. I applied the other changes. Thanks again, Bertrand http://codereview.appspot.com/4536068/
[Prev in Thread] | Current Thread | [Next in Thread] |