[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Modify chord-name-engraver to call capo-handler (issue4800051)
From: |
Carl Sorensen |
Subject: |
Re: Modify chord-name-engraver to call capo-handler (issue4800051) |
Date: |
Sun, 31 Jul 2011 16:35:02 -0600 |
On 7/31/11 4:17 PM, "Wols Lists" <address@hidden> wrote:
> On 31/07/11 22:00, Janek Warchoł wrote:
>> 2011/7/31 Wols Lists <address@hidden>:
>>>
>>> Assuming that it's okay and is applied, I've redone my docu patch.
>>
>> Uploaded to Rietveld. I see one trailing whitespace (after "By
>> default the chords are"), also there should be two spaces after a
>> period which ends sentence.
>>
>>> The snippet prints a four-bar phrase with just the standard chord
>>> (to trap the regression that bit us this time :-), then sets the capoPitch
>>> to print transposed chords for the next four bars, then sets capoVertical
>>> to print chords one above the other for the last four bars.
Do we need four bars? Why not just do three bars -- one with capoPitch '(),
another with capoPitch set, and a third with capoVertical?
We like to get examples and regtests as simple as can be.
>>>
>>> iirc that will then become the regression test for this feature?
>>
>> Yes, a regression test should contain a similar snippet. Could you
>> add the regression test file to your commit? (create a new file in
>> input/regression, named appropriately, use 'git add
>> input/regression/<your regtest filename>' to add it to what would be
>> commited, and commit.
>>
> Regression test attached. I've looked at the other regression tests and
> tried to make it similar. Basically just put the header stuff above my
> test/docu snippet.
This is exactly the right procedure. Thanks!
Thanks,
Carl
- Re: Modify chord-name-engraver to call capo-handler (issue4800051), (continued)
Re: Modify chord-name-engraver to call capo-handler (issue4800051), dak, 2011/07/30
Re: Modify chord-name-engraver to call capo-handler (issue4800051), lemniskata . bernoullego, 2011/07/31