[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
From: |
n . puttock |
Subject: |
Re: Rewrite regtest mozart-hrn-3.ly (issue4811066) |
Date: |
Tue, 02 Aug 2011 19:59:39 +0000 |
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode25
input/regression/mozart-hrn-3.ly:25: \fill-line { "This music is part of
the Mutopia project,"
newline
I suspect there's a missing \line here (where the extra braces were)
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode28
input/regression/mozart-hrn-3.ly:28: \fill-line { #(ly:export
(string-append "It has been typeset and placed in the public "
newline
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode29
input/regression/mozart-hrn-3.ly:29: "domain by " maintainer "."))
this is inside the scheme form, so its indentation should follow the
string above:
(string-append "It has been typeset and placed in the public "
"domain by " maintainer "."))
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode31
input/regression/mozart-hrn-3.ly:31: \fill-line { #(ly:export
(string-append "Unrestricted modification and redistribution"
newline
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode32
input/regression/mozart-hrn-3.ly:32: " is permitted and
encouraged---copy this music"
same indentation as above
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode33
input/regression/mozart-hrn-3.ly:33: " and share it!"))
indent
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode53
input/regression/mozart-hrn-3.ly:53: system-system-spacing
#'basic-distance = 10 \mm
remove \mm - it's redundant since the new spacing variables aren't
scalable (they're in terms of staff-space only)
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode54
input/regression/mozart-hrn-3.ly:54: score-system-spacing
#'basic-distance = 20 \mm
remove \mm
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode61
input/regression/mozart-hrn-3.ly:61: \header { piece = "Allegro" opus =
"" }
\header {
piece = "Allegro"
opus = ""
}
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode73
input/regression/mozart-hrn-3.ly:73: \header { piece = "Romanze" opus =
"" }
\header {
piece = "Allegro"
opus = ""
}
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode82
input/regression/mozart-hrn-3.ly:82: \layout {}
\layout { }
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode88
input/regression/mozart-hrn-3.ly:88: \header { piece = "Rondo" opus = ""
}
\header {
piece = "Rondo"
opus = ""
}
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily
File input/regression/mozart-hrn3-defs.ily (right):
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode16
input/regression/mozart-hrn3-defs.ily:16: \override MultiMeasureRest
#'padding = #0.5
this doesn't do anything; it's more likely to be MultiMeasureRestNumber
#'padding
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode22
input/regression/mozart-hrn3-defs.ily:22: \override Beam #'thickness =
#0.6
#'beam-thickness = #0.6
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode23
input/regression/mozart-hrn3-defs.ily:23: \override Beam
#'space-function = #(lambda (beam mult) 0.8)
#'length-fraction = #0.8
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode27
input/regression/mozart-hrn3-defs.ily:27: \override VerticalAxisGroup
#'minimum-Y-extent = #'(-2.5 . 3.5)
remove
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode32
input/regression/mozart-hrn3-defs.ily:32: indent = 10. \mm
10\mm
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode33
input/regression/mozart-hrn3-defs.ily:33: line-width = 189. \mm
189\mm
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-rondo.ily
File input/regression/mozart-hrn3-rondo.ily (right):
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-rondo.ily#newcode23
input/regression/mozart-hrn3-rondo.ily:23: rondo = \relative c' {
= \relative c'
http://codereview.appspot.com/4811066/