Re: Doc: Added \compoundMeter function to NR (issue4837050)

[pkx166h]

Second Draft. Hopefully I've covered everything without being too
verbose or talking through the code.

I also found some old 'scheme' code in the glossary and so updated that
with the new \compoundMeter function instead also removed another
reference to the snippet found in world.itely.


http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1555
Documentation/notation/rhythms.itely:1555: shown durations are
multiplied by 3/5 (3/5 * 10/8 = 3/4).  It may be
On 2011/08/03 06:50:15, Janek Warchol wrote:
> I think these parentheses might be confusing.  One can think that the
contents
> of the parentheses are to be multiplied by the fraction before it.

Only if you are a programmer :) it never even occurred to me to think of
them like that!

http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1555
Documentation/notation/rhythms.itely:1555: shown durations are
multiplied by 3/5 (3/5 * 10/8 = 3/4).  It may be
On 2011/08/04 08:31:35, Trevor Daniels wrote:
> The parentheses would be clear enough if we just reinsert "as" or
"since" at
> their start.

I used an 'en' dash. What do you think?

http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1634
Documentation/notation/rhythms.itely:1634: These can be easily created
using the @code{\compoundMeter} function.
On 2011/08/04 08:31:35, Trevor Daniels wrote:
> drop "easily"

Done.

http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1638
Documentation/notation/rhythms.itely:1638: \compoundMeter #'@var{(list
of numbers)}
On 2011/08/04 08:31:35, Trevor Daniels wrote:
> I agree.  First explain what a single list does, then move on to
explain
> multiple lists.

Done.

http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1638
Documentation/notation/rhythms.itely:1638: \compoundMeter #'@var{(list
of numbers)}
On 2011/08/04 11:12:21, Reinhold wrote:
> On 2011/08/03 06:50:15, Janek Warchol wrote:
> > the argument of \compoundMeter is a list of lists, not a list of
numbers.

> Actually, it can be both. In the simple case, like (2+2+3)/8 (which is
very
> common in e.g. Serbian folk music), you only have one fraction with a
sum in the
> enumerator.

> I would start with that "simpler" case of only one fraction and
describe
>     \compoundMeter #'(2 3 3 8)
> first.
> Then you can start from there and say that in the more complex case
with more
> fractions which are added, like 1/4 + 3/8, each fraction is expressed
as above,
> and all of them are put inside one list:
>     \compoundMeter #'((1 4) (3 8))


Done.

http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1638
Documentation/notation/rhythms.itely:1638: \compoundMeter #'@var{(list
of numbers)}
On 2011/08/04 11:12:21, Reinhold wrote:
> On 2011/08/03 06:50:15, Janek Warchol wrote:
> > the argument of \compoundMeter is a list of lists, not a list of
numbers.

> Actually, it can be both. In the simple case, like (2+2+3)/8 (which is
very
> common in e.g. Serbian folk music), you only have one fraction with a
sum in the
> enumerator.

> I would start with that "simpler" case of only one fraction and
describe
>     \compoundMeter #'(2 3 3 8)
> first.
> Then you can start from there and say that in the more complex case
with more
> fractions which are added, like 1/4 + 3/8, each fraction is expressed
as above,
> and all of them are put inside one list:
>     \compoundMeter #'((1 4) (3 8))


Done.

http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1638
Documentation/notation/rhythms.itely:1638: \compoundMeter #'@var{(list
of numbers)}
On 2011/08/04 11:12:21, Reinhold wrote:
> BTW, what I would definitely mention here is that the automatic
beaming and the
> beam subdivisions are automatically derived from  the \compound meter.
In
> particular, if you have a measure of five eighth notes,
>     \compoundMeter #'(2 3 8)
> will automatically beam them as 2 + 3 eighth notes, while
>     \compoundMeter #'(3 2 8)
> will automatically beam them as 3 + 2 eigth notes, and
>     \compoundMeter #'(4 1 8)
> will beam the first four and the print a single eigth note.

> Speaking in more music theory terms: A compound meter does not only
say how long
> the measure is, but it also gives the information about the beat
structure (the
> "meter"), ie. which notes are slightly accented. That's why I didn't
call it
> \compoundTime, but \compoundMeter. Lilypond automatically uses that
information,
> too.

That was a nice touch. Thanks, I have mentioned that.

http://codereview.appspot.com/4837050/