Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[ianhulin44]

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode324
scm/lily.scm:324: (> file-name-length 2)
On 2011/08/11 20:40:46, Neil Puttock wrote:
> tab->space conversion has broken indentation here (and lines below)

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode408
scm/lily.scm:408: ;; Library definitions, need to be at the head of the
list
On 2011/08/11 20:40:46, Neil Puttock wrote:
> this is a top-level comment, so you can't indent it two spaces

> (alternatively, put it inside the define)

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode412
scm/lily.scm:412: ;; Files containing definitions used later by other
files later in load
On 2011/08/11 20:40:46, Neil Puttock wrote:
> top-level comment; fix indent

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode415
scm/lily.scm:415: ;; Main body of files to be loaded
On 2011/08/11 20:40:46, Neil Puttock wrote:
> top-level comment; fix indent

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode467
scm/lily.scm:467: ;; Files to be loaded last
On 2011/08/11 20:40:46, Neil Puttock wrote:
> top-level comment; fix indent

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode476
scm/lily.scm:476: init-scheme-files-used
On 2011/08/11 20:40:46, Neil Puttock wrote:
> indent:

> (append init-scheme-files-lib
>          init-scheme-files-used
>          ...)

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode638
scm/lily.scm:638: (lambda (a b)
On 2011/08/11 20:40:46, Neil Puttock wrote:
> tab->space conversion has broken indentation here (and lines below)

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode770
scm/lily.scm:770: 'log-file (format #f "~a-~a"
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode779
scm/lily.scm:779: (acons (list-element-index joblist pid)
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode795
scm/lily.scm:795: job (status:term-sig state)))
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode802
scm/lily.scm:802: (map car errors)))
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode806
scm/lily.scm:806: '(0 0) (profile-measurements)))
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode817
scm/lily.scm:817: (string-contains f "lilypond")))))
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode831
scm/lily.scm:831: (format #f "~a.log" (ly:get-option 'log-file))
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode840
scm/lily.scm:840: (profile-measurements)
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode855
scm/lily.scm:855: (mtrace:dump-results base)))
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode857
scm/lily.scm:857: (ly:set-option (car s) (cdr s)))
On 2011/08/11 20:40:46, Neil Puttock wrote:
> restore indentation

Done.

http://codereview.appspot.com/4849054/diff/17001/scm/markup.scm
File scm/markup.scm (left):

http://codereview.appspot.com/4849054/diff/17001/scm/markup.scm#oldcode239
scm/markup.scm:239: (defmacro*-public markup (#:rest body)
On 2011/08/11 20:40:46, Neil Puttock wrote:
> move this for consistency?

I had some problems with other files in the load list on V2 if I moved
it, it works here for running with V1.8.7 now, so I'd rather not touch
it yet.

http://codereview.appspot.com/4849054/