[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Prevents nested tuplets from colliding. (issue 4808082)
From: |
address@hidden |
Subject: |
Re: Prevents nested tuplets from colliding. (issue 4808082) |
Date: |
Sat, 20 Aug 2011 10:30:01 +0200 |
On Aug 19, 2011, at 11:58 PM, address@hidden wrote:
>
>
> http://codereview.appspot.com/4808082/diff/13002/lily/tuplet-bracket.cc#newcode283
> lily/tuplet-bracket.cc:283: SCM scm_x_span = me->get_property
> ("X-positions");
> I seem to recall we discussed the option of splitting control-points
> into separate X/Y properties (can't remember exactly which grob it was
> for :).
Beams (I think...).
> My main concern was the naming since 'positions should be
> changed to Y-positions, but this would be disruptive for other grobs.
>
This could be done in a separate patch.
> http://codereview.appspot.com/4808082/diff/13002/lily/tuplet-bracket.cc#newcode669
> lily/tuplet-bracket.cc:669: // have to re_run numbers to check for
> number-on-number collisions
> This is getting a bit complicated. Do you think it's feasible to have a
> grob which would collect the colliding brackets and do the collision
> avoidance as a separate positioning-done callback?
>
This would certainly avoid the guestimation of the numbers' positions...
I'll do some digging and get back to you!
Cheers,
MS