Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047)

[Graham Percival]

On Tue, Aug 23, 2011 at 06:21:00PM +0000, address@hidden wrote:
> Maybe we should have some GOP rules for C++ about this?
> "Only have multiple exit points from routines if you absolutely have to.
> Make sure any output parameters are declared and initialized at the top
> of a routine so that however a routine exits, they are left in a defined
> state"

I don't think we need to wait that long (i.e. at least a month, if
not 2 or 3 months to get through GOP).  Regardless of the exit
points, any member variables or output parameters should be left
in a defined state.  IMO that's just basic sanity.  :)

Cheers,
- Graham