[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Creates pure closures (issue 4894052)
|
From: |
n . puttock |
|
Subject: |
Re: Creates pure closures (issue 4894052) |
|
Date: |
Wed, 31 Aug 2011 20:41:02 +0000 |
http://codereview.appspot.com/4894052/diff/19001/lily/system.cc
File lily/system.cc (right):
http://codereview.appspot.com/4894052/diff/19001/lily/system.cc#newcode773
lily/system.cc:773: || is_unpure_pure_container
(elts[i]->get_property_data ("Y-extent"))))
move this to pure-relevant?
http://codereview.appspot.com/4894052/diff/19001/lily/unpure-pure-container.cc
File lily/unpure-pure-container.cc (right):
http://codereview.appspot.com/4894052/diff/19001/lily/unpure-pure-container.cc#newcode54
lily/unpure-pure-container.cc:54: 2, 0, 0, (SCM unpure, SCM pure),
I'd make the pure part optional, if you're going to have grobs where
both parts are identical.
http://codereview.appspot.com/4894052/