[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Rietveld workflow problems

From: David Kastrup
Subject: Re: Rietveld workflow problems
Date: Wed, 21 Sep 2011 13:51:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Reinhold Kainhofer <address@hidden> writes:

> Am Wednesday, 21. September 2011, 12:45:17 schrieb David Kastrup:
>> Because it doesn't make sense to combine unrelated patches in that
>> manner.  You can't find them in the history then, and if the large patch
>> gets applied or reverted, the independent small patch has to go along.
> To submit a review to rietveld, the changes do not necessarily have to
> be in one single patch. If you do "git cl upload origin/master", all
> patches in your local branch will be submitted as one merged
> review.

Sure.  But there is no point in letting people review unrelated work
that has been merged into the total review.

> When pushing to git, you can still have multiple patches.

Even in the case where the patches are related by more than dependency,
it might make sense to be able to review several parts separately.
Increases the amount of work one can keep track of before eyes start
glazing over.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]