lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 483906


From: pkx166h
Subject: Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)
Date: Thu, 06 Oct 2011 20:50:15 +0000

Thanks Trevor and Graham. I also had to change an @ref in vocal.itely
because the node name changed.

Checked it all compiled.

commit  32c862967d559ab512cd96e3321a2c8dabe724ca


http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode950
Documentation/notation/changing-defaults.itely:950: contain it.  This
can give rise to unexpected new staves or scores.
On 2011/10/01 20:27:17, Trevor Daniels wrote:
I think this might be better placed at the end of this section.

Done.

http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode961
Documentation/notation/changing-defaults.itely:961: @lilypond[quote]
On 2011/10/01 20:27:17, Trevor Daniels wrote:
Hmm.  I think we do need verbatim here too to make it clear what is
being
demonstrated.

Done.

http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode961
Documentation/notation/changing-defaults.itely:961: @lilypond[quote]
On 2011/10/01 20:27:17, Trevor Daniels wrote:
Hmm.  I think we do need verbatim here too to make it clear what is
being
demonstrated.

Done.

http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode963
Documentation/notation/changing-defaults.itely:963: \new Staff { c' d'
e' f'
On 2011/10/01 20:27:17, Trevor Daniels wrote:
newline and indent

Done.

http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode964
Documentation/notation/changing-defaults.itely:964: \chords { d1:m7
b1:min7.5- }
On 2011/10/01 20:27:17, Trevor Daniels wrote:
indent

Done.

http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode971
Documentation/notation/changing-defaults.itely:971: \new Staff { c' d'
e' f'
On 2011/10/01 20:27:17, Trevor Daniels wrote:
newline and indent

Done.

http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode972
Documentation/notation/changing-defaults.itely:972: \chords { d1:m7
b1:min7.5- }
On 2011/10/01 20:27:17, Trevor Daniels wrote:
indent

Done.

http://codereview.appspot.com/4839061/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]