|Subject:||Re: convert-ly rule for beams|
|Date:||Mon, 17 Oct 2011 09:54:56 +0200|
On Oct 17, 2011, at 9:11 AM, David Kastrup wrote:
It's not that the functions didn't do useful things (ly:beam::calc-least-squares-positions, ly:beam::slope-damping, ly:beam::shift-region-to-valid), but rather they require tons of code duping for the calculations when consistent-broken-slope is set to #t in http://codereview.appspot.com/4961041. Even in their current form they have a fair bit of code duping. Furthermore, it seems that everywhere in the code, all of these functions were chained together before beam-quanting. There was/is nothing justifying their separate utility - in fact, their separateness was the cause for one bug (disagreements over common refpoints for collision grobs in beam quanting) that 4961041 fixes as a happy side effect. So, for all these reasons, I rolled all of these functions into the Beam_scoring_problem class as methods.
changes.tely makes sense - I doubt any developer will have any doubt about where these functions went, as they exist in the same part of beam-quanting.cc but are not callbacks anymore.
|[Prev in Thread]||Current Thread||[Next in Thread]|