Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

[k-ohara5a5a]

On Wed, 26 Oct 2011 11:40:27 -0700, address@hidden
<address@hidden> wrote:

> What needs comments?

Description of the different setup of the three instances of
Beam_scoring_problem, and their goals.

> -) the x-span of the Beam are stored in X-positions
(calc_x_positions).  these are used everywhere that the span of the beam
used to be calculated.  the slopes of broken beams were off before
because x_spans were calculated 3 different ways in 3 different
functions, and this standardizes it.

What is the standard ?
What is the span of the beam r8[ g' \beam a' r] ?
What about the x_span_ of the Beam_scoring_problem ?

Consistent slopes help a bit, but they way there is done here, the risks
of code complexity seem to outweigh the benefit.  The difference between
consistent_broken_slope_ and consistent_broken_slope is dangerous all by
itself.

> Take it for a spin!

Sorry. I have lost interest.


http://codereview.appspot.com/5293060/diff/2004/lily/beam-quanting.cc
File lily/beam-quanting.cc (right):

http://codereview.appspot.com/5293060/diff/2004/lily/beam-quanting.cc#newcode383
lily/beam-quanting.cc:383: x_span_ -= extremal_hangover_[d];
so x_span_ is the span from first normal stem to last normal stem.

http://codereview.appspot.com/5293060/