lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fixes issue 2005 (too much script padding between certain scripts and ac


From: mtsolo
Subject: Fixes issue 2005 (too much script padding between certain scripts and accidental) (issue 5328063)
Date: Wed, 02 Nov 2011 12:21:16 +0000

Reviewers: ,

Message:
Hey all,

This is my fault - sorry for it.  For some reason, the Mozart Horn
concerto does not show up in my regtest comparisons - otherwise I would
have spotted this.

Is this normal/intentional behavior?

If the Mozart horn concerto is not supposed to show up, I can add a
regtest.  Otherwise, the fix in the concerto should suffice as evidence
of the problem's being fixed.

Cheers,
MS

Description:
Fixes issue 2005 (too much script padding between certain scripts and
accidental)

Please review this at http://codereview.appspot.com/5328063/

Affected files:
  M lily/side-position-interface.cc


Index: lily/side-position-interface.cc
diff --git a/lily/side-position-interface.cc b/lily/side-position-interface.cc index 24422de6fd335094a44c27b26841ac8c105e5988..e2d328d5018296a2472515ef7a2f3ec700e323ff 100644
--- a/lily/side-position-interface.cc
+++ b/lily/side-position-interface.cc
@@ -174,7 +174,6 @@ Side_position_interface::skyline_side_position (Grob *me, Axis a,
   Direction dir = get_grob_direction (me);

   Box off;
-  Real my_min_h = dir == LEFT ? -infinity_f : infinity_f;
   for (Axis ax = X_AXIS; ax < NO_AXES; incr (ax))
     {
       if (ax == a)
@@ -187,12 +186,9 @@ Side_position_interface::skyline_side_position (Grob *me, Axis a,
   if (off[X_AXIS].is_empty () || off[Y_AXIS].is_empty ())
     return scm_from_double (0.0);

-  my_min_h = off[a][dir];
-
   Real skyline_padding = 0.1;

   Skyline my_dim (off, skyline_padding, other_axis (a), -dir);
-  my_dim.set_minimum_height (my_min_h);

   bool include_staff
     = staff_symbol





reply via email to

[Prev in Thread] Current Thread [Next in Thread]