lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Improve HTML output of regression tests (issue 5342042)


From: dak
Subject: Re: Improve HTML output of regression tests (issue 5342042)
Date: Mon, 07 Nov 2011 09:15:05 +0000


http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):

http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304
scripts/build/output-distance.py:1304: if len (args) % 2 == 1:
On 2011/11/07 08:52:52, Graham Percival wrote:
why is there a mod here?  Surely we just want to check if the length
of args is
0 (or maybe 1 depending on how they're counted).  As it currently
stands,
doesn't it print usage whenever there's an odd number of arguments?

Uh, yes?  See line 1313: the argument list consists of an arbitrary
number of _pairs_.

http://codereview.appspot.com/5342042/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]