Re: avoid cryptic StopIteration failure from make when 'make check' is run before 'make test-baseline' (issue 5361042)

[ianhulin44]

On 2011/11/06 21:30:18, adam.spiers wrote:
> I disagree - there is no way to be sure that the cause of the
StopIteration
> really was the user failing to run make test-baseline first.  For
example he
> could have run it but then something else accidentally (or
deliberately) deleted
> those directories.  That's why I deliberately phrased it as a question
- it's
> intended to prompt the user into switching their brain into
diagnostics mode.
> If they choose to ignore the warnings, well, that's their problem :-)

Hmmm... If you're giving a warning, just state the facts, making it a
question is bad "headology" as they may interpret it as *you* being
unsure of what you're reporting.
It's a detail, and doesn't need to be a deal-breaker.


You're right, though, if they can't RTFW (Read The Finely-crafted
Warning (:==:)), they deserve everything they get.
Having the diagnostic LGTM.
Ian

http://codereview.appspot.com/5361042/