[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

From: Carl Sorensen
Subject: Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)
Date: Mon, 7 Nov 2011 23:41:46 +0000
User-agent: Microsoft-MacOutlook/

On 11/7/11 2:48 PM, "Adam Spiers" <address@hidden> wrote:

>On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival
><address@hidden> wrote:
>> On Mon, Nov 07, 2011 at 08:13:46PM +0000, address@hidden
>>> I am not in favor of the tab-to-space change in
>>> scm/chord-ignatzek-names.scm, since we don't yet have agreement on
>>> removing tabs from .scm files, AFAICS.
>> True, but I assume that other parts of the patch set depend on
>> this, and high-quality work, so I vote for turning a blind eye to
>> this change and accepting the patch set.
>Thanks - I tried removing it and rebasing, but it was more work than
>I have time for.  I'm already about 1000% over budget on all this.

As I mentioned earlier, I agree with this decision.

However, I should mention that I rebased things to take that whitespace
change out, and if Graham had let me finish serving as frog-meister for
this patch (I got the assignment to do so last Thursday), we'd have a
patch set up without the whitespace changes.

I don't want to revisit any of these decisions for this time -- let's just
get the bugfix in the maoing source tree.  But I *am* a bit frustrated
that my work was all in vain.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]