[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

From: Keith OHara
Subject: Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)
Date: Mon, 07 Nov 2011 21:33:43 -0800
User-agent: Opera Mail/11.52 (Win32)

On Mon, 07 Nov 2011 20:51:14 -0800, address@hidden <address@hidden> wrote:

I'm OK with getting rid of all of this pure-from-neighbor and span-bar-stub 
stuff and just create several SpanBars instead of one SpanBar with gaps in its 
stencil.  I can reuse code I've already written, so it's not that bad.

Would you do it as a revert of 4f49b000 followed by a commit to make a clean 
fix for issue 910 ?

But, my question is: was it ever a good idea to have the pure heights of span 
bars calculated the way they were?  SpanBars are inherently cross staff, so how 
can they estimate a correct Y-extent without triggering a VerticalAlignment?

The correct height for SpanBars during note-spacing would be whatever 
corresponds to the tentative staff-spacing used during horizontal spacing -- 
the spacing table for which you recently implemented caching.  SpanBars did 
have that as their Y-extent in 2.14.  (But of course they did not have the 
proper gaps in their skylines, if somebody used 'allow-span-bar=#f)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]