lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Improves horizontal spacing of axis groups that SpanBar grobs traver


From: k-ohara5a5a
Subject: Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)
Date: Thu, 10 Nov 2011 07:19:13 +0000

On 2011/08/30 16:28:28, mikesol_ufl.edu wrote:
On Aug 30, 2011, at 5:53 PM, mailto:address@hidden wrote:

> Correct me if I'm wrong, but this is my understanding: wherever
there's
> a SpanBar, you're creating SpanBarStubs between every relevant pair
of
> staves. These don't actually get printed; they're just there for the
> pure-height (because the SpanBar height is pretty much the whole
system,
> so it doesn't tell you where the gaps are).
>

Yes.

> If that's correct, I have two broad comments: it's worth commenting
> somewhere (span-bar-stub-engraver.cc, maybe) that the purpose of
> SpanBarStub is for pure-height only.

Will do.


Haven't done yet.

> But more importantly, isn't SpanBar
> now obsoleted by SpanBarStub? That is, you can just remove the
SpanBar
> altogether and print the SpanBarStubs.
>

Mmm...you're not unright, but I'd prefer to do that in another patch
if that's
OK.  It'd require a lot of deleting and moving around, and I'd first
like to
make sure that these stubs are the code base and bug free for a while
before I
deprecate an entire grob (and figure out how to deal with the syntax
changes
that come with said deprecation).


Well, the SpanBarStub extent is not the full length to bridge between
BarLines, it is only the height of the Lyrics, and only those Lyrics in
the neighboring measures.

SpanBarStub needs to change size, or get a bar-extent different from its
Y-extent, before it can take over the job of printing SpanBars.

I'm worried the code will be quite difficult to understand for quite a
while unless Mike retreats.


http://codereview.appspot.com/4917046/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]