lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: This removes ly:export for real and separates read/eval for Scheme e


From: dak
Subject: Re: This removes ly:export for real and separates read/eval for Scheme expressions. (issue 5370048)
Date: Fri, 11 Nov 2011 20:49:29 +0000

Reviewers: J_lowe,

Message:
On 2011/11/11 18:24:38, J_lowe wrote:
This fails make (petty instantly actually)

Since it removes source files, you need to remake the dependencies.

Description:
This removes ly:export for real and separates read/eval for Scheme
expressions.

Patches are:


Separate read/eval for Scheme expressions.


Remove all traces of ly:export


Again, this is blocked on issue 2024 (naturally) and starts with the
state committed there.  And remember that issue 2024 is blocked by
VERSION bumping to 2.15.18 if you want to take this for a test ride.

Something like

zap=4


will now work properly since the Scheme expression is only evaluated
once it is consumed in the parser, not when it is read, lexed or
becoming the lookahead token.  In contrast,

zap=4
$(display zap)

fails just like it did previously, since it is evaluated in the lexer.

Please review this at http://codereview.appspot.com/5370048/

Affected files:
  M Documentation/extending/scheme-tutorial.itely
  D lily/identifier-smob.cc
  D lily/include/identifier-smob.hh
  M lily/include/lily-lexer.hh
  M lily/include/parse-scm.hh
  M lily/lexer.ll
  M lily/parse-scm.cc
  M lily/parser.yy
  M scm/markup-macros.scm
  M scm/markup.scm
  M scm/safe-lily.scm





reply via email to

[Prev in Thread] Current Thread [Next in Thread]