[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

From: Carl . D . Sorensen
Subject: Re: Adds padding between Hairpins and SpanBars. (issue 5438060)
Date: Mon, 28 Nov 2011 01:24:34 +0000

Looks pretty good.  Thanks for hitting this so quickly.  Just a couple
of stylistic comments.


File lily/include/system.hh (right):
lily/include/system.hh:45: Grob * get_neighboring_staff (Direction dir,
Grob *vag);
*vag should be *vertical_axis_group for clarity in the header file, IMO.

In the engraver, the code that defines vag shows it to be a
vertical_axis_group, so I'm ok with it there.
File lily/ (right):
lily/ System::get_neighboring_staff (Direction dir, Grob
Here, *vag should be *vertical_axis_group because there is no context
for understanding what it means.
File scm/define-grob-properties.scm (right):
scm/define-grob-properties.scm:1047: (has-span-bar ,pair? "A pair of
span bars indicating whether a a span bar
"A pair of grobs containing the span bars to be drawn above and below
the staff.  If no span bar is in a position, the respective element is
set to @code{#f}."

Is this a correct statement?  If so, I think it's clearer than the
current wording.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]