[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: item.cc: make is_non_musical() conform to its name (issue 5373048)
From: |
mtsolo |
Subject: |
Re: item.cc: make is_non_musical() conform to its name (issue 5373048) |
Date: |
Wed, 30 Nov 2011 08:49:50 +0000 |
LGTM.
I like the fact that this brings the function name in line with the
function's function - it'll make it easier on future users of the
function to understand what's going on.
I won't have time to test it today, but I'm assuming that the change
doesn't have adverse effects in other places where non_musical is used.
Cheers,
MS
http://codereview.appspot.com/5373048/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: item.cc: make is_non_musical() conform to its name (issue 5373048),
mtsolo <=