Re: Make failing

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: "Phil Holmes" <address@hidden>
Cc: <address@hidden>; "David Kastrup" <address@hidden>
Sent: Monday, December 19, 2011 5:29 PM
Subject: Re: Make failing


> On Dec 19, 2011, at 6:25 PM, Phil Holmes wrote:
>
> > ----- Original Message ----- From: "David Kastrup" <address@hidden>
> > To: <address@hidden>
> > Sent: Monday, December 19, 2011 5:04 PM
> > Subject: Re: Make failing
> >
> >
> > > "Phil Holmes" <address@hidden> writes:
> > > > On my build Ubuntu machine, make is currently failing with the
> > > > following output:
> > > >
> > > > /home/phil/lilypond-git/lily/score-engraver.cc: In member function
> > > > virtual void Score_engraver::announce_grob(Grob_info)':
> > > > /home/phil/lilypond-git/lily/score-engraver.cc:164: error:
> > > > VALGRIND_PRINTF_BACKTRACE' was not declared in this scope
> > > > make[1]: *** [out/score-engraver.o] Error 1
> > > > make[1]: Leaving directory
> > > > /media/IntelSSD/lilypond/lilypond-git/build/lily'
> > > > make: *** [all] Error 2
> > > >
> > > > This looks like a problem with Mike's latest patch - I assume it
> > > > requires valgrind to be present on the build machine, and it's not on
> > > > mine.  Debug code?
> > > >
> > > > +    {if (info.grob ()->name () == "StemStub")
> > > > VALGRIND_PRINTF_BACKTRACE ("foo");
> > > How could that have slipped by Patchy?  Graham?
> > > --
> > > David Kastrup
> >
> >
> > My guess was that patchy is running on a system with Valgrind.
>
> Sorry...forgot to remove my debug code.
> Do you want me to push a fix to staging?
>
> Cheers,
> MS


David or Graham are probably better able to comment, but it seems to me we 
need a patch pushed to master to get that back in shape.  Not sure whether 
this will break staging, though.

--
Phil Holmes