Re: [PATCH] Documentation search - update version and Google syntax

[James]

Pavel,

On 4 January 2012 22:32, Pavel Roskin <address@hidden> wrote:
> Hello!
>
> There are two issues with the search box in the online documentation.
> One is that search in v2.15 documentation adds +v2.14 to the
> Google search, so it look in the older documentation.
>
> The other is that "+" doesn't have the old meaning since the
> introduction of Google Plus.  To ensure that "v2.15" appears on the
> page or in the URL, it should be added in quotes.
>
> A simpler alternative would be to use this in the search:
>
> site:lilypond.org/doc/v2.15
>
> That would tell Google to search documents only under
> lilypond.org/doc/v2.15, which is probably our intention.
>
> Here's the patch.  Please let me know if a sign off or something like
> that is needed.  It's my first ever patch for LilyPond.

Thank you. There is a review process that does need to be followed.

If you intend on doing more work for LilyPond then can you read:

http://lilypond.org/doc/v2.15/Documentation/contributor-big-page#summary-for-experienced-developers

In this case start at the 'reviews' bullet point about half way down.

(I don't know your level of expertise so am assuming you are
comfortable with these instructions)

Essentially we have a tracker issue on Google code for logging the
issues and we use Rietveld (all explained in the above link) for code
review.

However if you do not intend to do more LilyPond dev work then I am
happy to handle this patch for you, but I'd prefer a git formatted
patch if possible or at the very least a 'diff' file that I can then
post for review on your behalf.

This email seems to have just put the diffs inline (at least on my
email reader).



-- 
--

James