Re: Implements rhythmic-music-iterator (issue 5554048)

[mtsolo]

Reviewers: dak,


http://codereview.appspot.com/5554048/diff/2001/lily/rhythmic-music-iterator.cc
File lily/rhythmic-music-iterator.cc (right):

http://codereview.appspot.com/5554048/diff/2001/lily/rhythmic-music-iterator.cc#newcode41
lily/rhythmic-music-iterator.cc:41: report_event (get_music ());
On 2012/01/18 13:38:39, dak wrote:
> I suppose that one has to clear "articulations" here (after fetching
them), or
> they will get treated by both report_event as well as the rhythmic
iterator.

Good call.  A new patch set is up that fixes this.  It adds some extra
verbage, but it makes sure that:
a) Notes are reported without their articulations; and
b) Articulations are reported after notes.

This should prevent the new-fingering-engraver from seeing the
articulations.  Furthermore, given the way that the music stream
currently looks, articulations are placed after notes in an event chord.
 In theory this shouldn't matter, but in case it does, this puts the
loop after the first report_event.

Description:
Implements rhythmic-music-iterator

Please review this at http://codereview.appspot.com/5554048/

Affected files:
  A lily/include/rhythmic-music-iterator.hh
  A lily/rhythmic-music-iterator.cc
  M scm/define-music-types.scm