[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Q: patchy-test and patchy-merge
From: |
David Kastrup |
Subject: |
Re: Q: patchy-test and patchy-merge |
Date: |
Sun, 05 Feb 2012 12:07:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) |
"Phil Holmes" <address@hidden> writes:
> My current patchy understanding of patchy is that patchy-merge runs
> make and make test,
And make doc.
> and if these are OK then it pushes staging to master. AFAICS from the
> code, it requires quick_make=True to do a doc build and regtest
> comparison, and this is false for the normal run.
Sure? It does not regtest _comparison_ IIRC (since that is the job of
patch review), but it runs the regtests and the docs. And it takes its
time...
> It's the job of patchy-test to check that a patch is OK to consider
> for pushing to staging, and this includes make doc and a regtest
> comparison.
>
> So the process flow should be: patch goes for review. It should be
> reviewed by relevant devs and by patchy-test and should receive a
> "autobot says LGTM" before getting counted down and receiving
> permission to push. It's pushed to staging and gets the less rigorous
> testing from patchy-merge but sufficient to ensure make is (almost)
> guaranteed to work on master.
>
> Probably wrong, but my best guess to date.
More or less.
--
David Kastrup