[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: some comments and complaints on the code (issue 5651069)
|
From: |
hanwenn |
|
Subject: |
Re: some comments and complaints on the code (issue 5651069) |
|
Date: |
Mon, 13 Feb 2012 11:35:39 +0000 |
http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc
File lily/note-collision.cc (right):
http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc#newcode587
lily/note-collision.cc:587: for_UP_and_DOWN (d)
On 2012/02/13 11:33:48, hanwenn wrote:
after reading some of the code, this actually looks nice.
Can you rename it
for_updown ?
for brevity and writability? There should also be a for_leftright()
also, this change should be separated out.
Build consensus on the list, and then fix all of the codebase in one go.
http://codereview.appspot.com/5651069/
- Re: some comments and complaints on the code (issue 5651069), (continued)
Re: some comments and complaints on the code (issue 5651069), janek . lilypond, 2012/02/11
Re: some comments and complaints on the code (issue 5651069), milimetr88, 2012/02/11
Re: some comments and complaints on the code (issue 5651069), janek . lilypond, 2012/02/11
Re: some comments and complaints on the code (issue 5651069), k-ohara5a5a, 2012/02/11
Re: some comments and complaints on the code (issue 5651069), joeneeman, 2012/02/12
Re: some comments and complaints on the code (issue 5651069), hanwenn, 2012/02/13
Re: some comments and complaints on the code (issue 5651069),
hanwenn <=
Re: some comments and complaints on the code (issue 5651069), janek . lilypond, 2012/02/16