[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Question for Han-Wen (Re: Checks to see that stencil commands have the c
From: |
address@hidden |
Subject: |
Question for Han-Wen (Re: Checks to see that stencil commands have the correct number of arguments. (issue 5649054)) |
Date: |
Tue, 14 Feb 2012 09:16:59 +0000 |
On Feb 12, 2012, at 3:21 PM, address@hidden wrote:
>
> http://codereview.appspot.com/5649054/diff/1/lily/stencil-expression.cc
> File lily/stencil-expression.cc (right):
>
> http://codereview.appspot.com/5649054/diff/1/lily/stencil-expression.cc#newcode31
> lily/stencil-expression.cc:31: nargs = scm_permanent_object (scm_cons
> (scm_cons (ly_symbol2scm ("dummy"), SCM_EOL), SCM_EOL));
> dummy?
>
> The whole stuff is totally incomprehensible. It is not clear what is
> stored where and for what reason, and there is no documentation
> whatsoever. It was bad before, agreed, but it has become much worse.
Han-Wen,
Is there a specific reason for using a permanent Scheme variable in the C++
instead of a lookup call to the lily module? If it's just happenstance then
I'll move these structures to Scheme and access them from the Scheme module.
Cheers,
MS