Re: Open strings in chords (commit 9203eadca5bcb79415060f8488889706a9c8e62a)

[Marc Hohl]

Am 14.02.2012 21:01, schrieb David Kastrup:
> Marc Hohl<address@hidden>  writes:
>
> > Am 14.02.2012 09:58, schrieb Marc Hohl:
> > +    \set TabStaff.handleOpenStrings = #'forbid
> > +<  g, d>1
> > +  }
> > +}
> > diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
> > index 6335ab6..11181d3 100644
> > --- a/ly/engraver-init.ly
> > +++ b/ly/engraver-init.ly
> > @@ -46,6 +46,7 @@
> >
> >     predefinedDiagramTable = #default-fret-table
> >     handleNegativeFrets = #'recalculate
> > +  handleOpenStrings = #'allow
> Symbols 'allow and 'forbid are not a typical interface.  You would
> rather use a boolean here.
Yes, you are right, I changed it accordingly.
> Would it make sense to specify a _list_ minimumFretExceptions that is
> not checked against minimumFret?
>
> Or is the only exception ever of interest the fret 0?
Speaking as a guitarist, I think that only 0 makes sense.
When I specify minimumFret = #7, I normally stay in this
range. In some situations open strings make sense, but
this should be switchable - to include a complete list of
minimumFretExceptions would be overkill.

Thanks for your suggestions!

Marc

0001-Handling-of-open-strings-in-tablature.patch.txt
Description: Text document