Re: Fix for several musicxml2ly bugs. (issue 5697059)

[julien . rioux]

This patch is not associated with any issue in the bug tracker. It will
not get a proper review until it is added there, and the automatic
testing shows that it does not cause any unexpected problems. Should it
be added to issue 1983, or is it sufficiently different that we should
open a new issue for it?

There are a lot of formatting changes to musicxml.py that are
unnecessary and make it difficult to see the meaningful changes in your
patch. You also introduce whitespace errors. So please revert the
changes to musicxml.py except for...


http://codereview.appspot.com/5697059/diff/1/scripts/musicxml2ly.py
File scripts/musicxml2ly.py (right):

http://codereview.appspot.com/5697059/diff/1/scripts/musicxml2ly.py#newcode25
scripts/musicxml2ly.py:25: # Store command-line options in a global
variable, so we can access them everywhere
...this typo...

http://codereview.appspot.com/5697059/diff/1/scripts/musicxml2ly.py#newcode534
scripts/musicxml2ly.py:534: return None
...and this thinko.

http://codereview.appspot.com/5697059/diff/1/scripts/musicxml2ly.py#newcode2570
scripts/musicxml2ly.py:2570: p.version = ('''%prog (LilyPond)
2.15.24\n\n'''
Especially, don't change this.

http://codereview.appspot.com/5697059/